Replace homegrown config parser with figment #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace usage of humantime::Duration with std::time::Duration in UpdateInterval. As a drive-by for the future, add serializer support to UpdateInterval. Use humantime-serde crate for that. Remove old unused fork that was in humantime_wrapper_serde.rs, there's no need to store a humantime::Duration in the interval, it's sufficient to store just an std::time::Duration and do parsing and formatting as appropriate. Presumably I wrote the fork because I thought I needed the FromStr impl that humantime::Duration provided.
Add figment, figment_file_provider_adapter, humantime-serde packages. Enable the clap derive feature to switch to derive-style argument parsing. Enable the secrecy serde feature to allow serialization of secrets (needed for token configuration management).
alcroito
added
dependency
Use figment for parsing configuration from env vars, cli, toml file. Switch from clap builder api to clap derive api. This creates a struct that then be fed to figment. Remove old homegrown config builder. Remove direct toml dependency, it's handled by figment now. Update documentation concerning booleanss and numbers. BREAKING CHANGE: toml booleans and numbers in the config files can't be quoted anymore. Previously they had to be quoted strings due to implementation issues.
Shows nicer error reports when a test fails. Because the install hook needs to be called once per process, and cargo runs tests in parallel in the same process, the install hook needs to be protected by a OnceCell. Inspired by https://github.com/yaahc/color-eyre/pull/118/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: toml parsing is now strict, so existing configuration files need to be updated to ensure booleans and numbers aren't quoted anymore (and thus treated as strings).