Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: maintenance routine #3

Merged
merged 2 commits into from
Nov 5, 2023
Merged

chore: maintenance routine #3

merged 2 commits into from
Nov 5, 2023

Conversation

aldy505
Copy link
Owner

@aldy505 aldy505 commented Nov 5, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3465c2d) 97.19% compared to head (aa4034f) 96.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   97.19%   96.34%   -0.86%     
==========================================
  Files           6        6              
  Lines         321      410      +89     
==========================================
+ Hits          312      395      +83     
- Misses          6       11       +5     
- Partials        3        4       +1     
Files Coverage Δ
bcrypt/bcrypt.go 91.89% <100.00%> (-0.97%) ⬇️
pbkdf2/pbkdf2.go 98.11% <100.00%> (+0.46%) ⬆️
scrypt/scrypt.go 92.40% <100.00%> (-0.58%) ⬇️
argon2/argon2.go 95.65% <62.50%> (-2.88%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 merged commit a417b31 into master Nov 5, 2023
16 of 19 checks passed
@aldy505 aldy505 deleted the chore/maintenance-routine branch November 5, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant