-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Catppuccin for all variants #687
Conversation
Signed-off-by: jolheiser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are just the things that immediately jumped out to me.
I'd either like to spend some more time tomorrow reviewing the highlights, or send another PR to implement those changes, should I find any.
Co-authored-by: winston <[email protected]>
@nekowinston did you want to do another review or should I appease the linter gods? |
I don't suppose either of you have encountered a commonly used machine-readable format for themes? |
Signed-off-by: jolheiser <[email protected]>
I haven't, because most have their own set of keys/values available. I've appeased the linter, I think this is ready to go. Anything further can happen in a follow-up, as it wouldn't change names and so shouldn't break anything, |
Looks 🔥 🔥 Excited to see this get merged! |
I think we're waiting for another pass by @nekowinston , let's give it another day or two then remind me to merge it. |
@alecthomas I think we're okay to merge this. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for causing a delay here - this seems fine. We should really work on a more defined styleguide, so that we have more defined docs which colors should map to which tokens; but this seems good for now.
👍 Thanks everyone! |
Resolves #686
❗ I've removed the
catppuccin
theme and replaced it withcatppuccin-mocha
in order to make them all standard. Let me know if you want me to change it back to justcatppuccin
, I realize it's potentially a breaking change but there hasn't been a new release cut and it's only been merged for a few days, so I changed it for now.The following previews are HTML of the HTML code of these variants, because inception is cool and the Go lexer doesn't show off enough of the colors based on just the style's Go file. 😅
Latte
Frappe
Macchiato
Mocha