Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OrderedDict validation, including as the return type #255

Closed
wants to merge 1 commit into from
Closed

Conversation

SimplyKnownAsG
Copy link
Contributor

This addresses #254, which I created earlier. The fix is pretty simple, sorry for the stupid formatting stuff, I can get rid of those changes as you desire.

One thing I thought was going to be an isuses was ensuring that data is a dict; however, that is already done in the validate_dict closure (right?).

@SimplyKnownAsG
Copy link
Contributor Author

@alecthomas, the CI failed because Python2.6 does not have a collections.OrderedDict. Is it acceptable to disable the test if collections.OrderedDict does not exist?

@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 95.968% when pulling eb54de2 on SimplyKnownAsG:master into f1b5aa8 on alecthomas:master.

@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 95.968% when pulling 1ab9238 on SimplyKnownAsG:master into f1b5aa8 on alecthomas:master.

@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 95.968% when pulling 1ab9238 on SimplyKnownAsG:master into f1b5aa8 on alecthomas:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants