Added validation for default values #324
Conversation
|
Don't know what exactly caused the travis build to fail, but it seems not related to my changes. At least I hope so :-). |
| error = None | ||
| errors = [] | ||
| for key, value in iterable: | ||
| for key, value in key_value_map.items(): |
There was a problem hiding this comment.
I'm pretty sure this line is what's causing the test failure. key_value_map is not an OrderedDict so it fails the ordering guarantee.
|
Oh, I haven't looked deeper into that. Is there a reason you want to guarantee ordering? Since it's just key/value validation order shouldn't matter, should it? |
|
If the user is validating an |
|
Cool, that made it pass through. |
bob1de
force-pushed
the
validate_defaults
branch
from
c2a328d
to
9f91655
Compare
|
Thanks! |
|
You're welcome. Is there already a schedule for the release this is going to be included in? As it will break backwards compatibility with badly written schemas I suppose it will going to be 0.11.0... |
The change in pull request alecthomas#324 can be backward incompatible if a default value does not validate against the schema
The change in pull request #324 can be backward incompatible if a default value does not validate against the schema
Upstream changes are many minor improvements and bugfixes, plus **Changes** - [#378](alecthomas/voluptuous#378): Allow `extend()` of a `Schema` to return a subclass of a `Schema` as well. **Changes**: - [#349](alecthomas/voluptuous#349): Support Python 3.7. - [#343](alecthomas/voluptuous#343): Drop support for Python 3.3. **Changes**: - [#293](alecthomas/voluptuous#293): Support Python 3.6. - [#294](alecthomas/voluptuous#294): Drop support for Python 2.6, 3.1 and 3.2. - [#318](alecthomas/voluptuous#318): Allow to use nested schema and allow any validator to be compiled. - [#324](alecthomas/voluptuous#324): Default values MUST now pass validation just as any regular value. This is a backward incompatible change if a schema uses default values that don't pass validation against the specified schema. - [#328](alecthomas/voluptuous#328): Modify `__lt__` in Marker class to allow comparison with non Marker objects, such as str and int.
Hi,
This PR adds validation for default values as discussed with @alecthomas in #264.
I tested the changes locally and got the expected behaviour so far, unittests passed as well.
It has to be mentioned that this breaks backwards compatibility if one used default values before which would now fail validation, but doing so should be considered as bad practice IMHO anyway. So this change should encourage to not insert default values that violate ones own schema.
Best regards
Robert