Allow a discrminant field in validators #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alecthomas did you want to comment on this? |
|
It's hard to tell as the doctest doesn't actually test it? |
alecthomas
reviewed
Aug 15, 2019
voluptuous/validators.py
Outdated
| """Use the first validated value among those selected by discrminant. | ||
|
|
||
| :param msg: Message to deliver to user if validation fails. | ||
| :param discriminant: Function to filter the values |
There was a problem hiding this comment.
Can you move the signature description into this param comment please.
|
Thanks! |
|
HI @alecthomas ! I saw that this repo is contributions only, but will you still make release from master from time to time ? (I'm interested about this feature and was wondering if it has a chance to be released or not) Thanks for the work on this library 👍 |
|
Yep, definitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #360
The accepted solution was to add a
Uniontype which requires a discriminant. What I have done is check for adiscrminantargument, and run thevalueand alternatives through the discriminant function to obtain a filtered list of alternatives. This allows a discriminant field to be included in the existing typesSince the validators are compiled before execution, when using the
_WithSubValidatorsclass, and thevalueis available during execution I cannot check if it is accepted by the discriminant or not any earlier than execution. In such a case I'd have to recompile the validators obtained from the discriminant.I have a bunch of
printstatements committed which I will remove once this is approved.