-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow error reporting on keys #479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
20 tasks
bdraco
reviewed
Jun 23, 2024
Comment on lines
+433
to
+435
if error: | ||
errors.append(error) | ||
elif remove_key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it introduced a regression and vol.Remove doesn't work anymore
I think it needs to be reversed
if remove_key:
# remove key
continue
elif error:
errors.append(error)
bdraco
added a commit
to bdraco/voluptuous
that referenced
this pull request
Jun 23, 2024
fixes a regression from alecthomas#479 blocks alecthomas#479
alecthomas
pushed a commit
that referenced
this pull request
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tweaked the error reporting code in voluptuous/schema_builder.py so that validation errors on keys are reported with a message based on the exception raised rather than treated as an extra key. With this change exceptions on keys are treated in the same was as exceptions on values.
Before the change, when an Invalid error is raised on a key, the specifics of the error raised are ignored and the problem was reported as an extra key. This results in several problems. First, the reported error can be misleading. Second, the error could go unreported if the extra parameter is passed as REMOVE_EXTRA or ALLOW_EXTRA to Schema.
One example where this was problematic is a case where I was expecting the keys to be dates, and any invalid dates, such as February 30, should be reported as invalid dates, but instead were reported as an extra key, which is confusing.
Here is a short program that illustrates the problem: