Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Alt keybindings on Windows #13

Closed
csholmq opened this issue Feb 12, 2016 · 6 comments
Closed

Ctrl+Alt keybindings on Windows #13

csholmq opened this issue Feb 12, 2016 · 6 comments
Assignees
Labels
bug depends on Depends on issues from VS Code

Comments

@csholmq
Copy link

csholmq commented Feb 12, 2016

image

Both Notepad++ and Atom uses F2. Set/Unset with e.g. Shift+F2 and then F2 to jump between.

@alefragnani
Copy link
Owner

Yes, I remember that, but F2 and Ctrl + F2 are already used as Code commands:

{ "key": "f2",                    "command": "editor.action.rename",
                                     "when": "editorTextFocus" },
{ "key": "ctrl+f2",               "command": "editor.action.changeAll",
                                     "when": "editorTextFocus" },

I tried to use Ctrl + Shift + K instead, but it was already being used as editor.action.deleteLines, so I ended up using the actual combination Ctrl + Alt + K to toggle, J and L to navigate. Besides this warning in console, the keybindings works fine.

But, the good about Code (just like Atom) is that you can define you own keybinds, as described in https://code.visualstudio.com/docs/customization/keybindings.

Hope this helps.

@csholmq
Copy link
Author

csholmq commented Feb 13, 2016

That's true. But as Ctrl+Alt can block special characters on non US keyboard layouts, perhaps the defaults should avoid that?

@alefragnani
Copy link
Owner

Hm, I didn't know the warning message was about that, I'm sorry. Since it was working fine for me (on a Windows Machine), and didn't find any docs about that, I thought it was some kind of false positive. I will take extra care next time when choosing keybindings.

I understand your point, but what about the users that already installed the extension? If I change the default keybinding, the extension will stop working for them 😞 . Personally, I have no problem about changing the keybidings for shift+alt for instance, but as I said, I'm worried with the current users.

I will try to contact VSCode team, asking them for an advice on how I could handle this. Maybe they have a workaround that could handle existing users.

Thanks

@alefragnani alefragnani self-assigned this Feb 14, 2016
@alefragnani
Copy link
Owner

Some ideas:

  1. Display a message right after updating the extension, asking if they want to keep the old keybinding, or replace with the new. Because only add this info in the Readme wouldn't be enough.
  2. Create different Keybindings depending on Keyboard Layout Support contributing different keybindings based on keyboard layout microsoft/vscode#1240

@alefragnani alefragnani removed this from the 0.10.0 milestone Oct 21, 2016
@alefragnani
Copy link
Owner

There is no ETA for the VS Code API to be available, and so, I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug depends on Depends on issues from VS Code
Projects
None yet
Development

No branches or pull requests

2 participants