Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support virtual workspaces #501

Closed
lszomoru opened this issue May 7, 2021 · 3 comments
Closed

Support virtual workspaces #501

lszomoru opened this issue May 7, 2021 · 3 comments
Assignees
Labels
duplicate enhancement remote Remote Development vscode api adoption Adopting new/updated VS Code APIs
Milestone

Comments

@lszomoru
Copy link

lszomoru commented May 7, 2021

👋 Hi there, Martin here, from the VS Code team.

Recently we've announced the Remote Repository feature that lets you browse and edit files and folders directly on GitHub.

Open Remote Repository... opens VSCode on a folder or workspace located on a virtual file system. We call this a virtual workspace. We observed that not all extension support this well, either because they can not, or they haven't thought about it.

It would be fantastic if you could test whether your extension can handle virtual workspaces:

Check out the Virtual Workspaces Extension Author Guide on how to do that.

When done, set the new virtualWorkspaces capability in your 'package.json'.

{
  "capabilities": {
    "virtualWorkspaces": true | false
  }
}
  • Use "virtualWorkspaces": true if your extension is prepared for virtual workspaces
  • Use "virtualWorkspaces": false if your extension should be disabled when a virtual workspace is opened

For questions and comments please use the Virtual Workspaces Tracking Issue.

Thanks for the support and the great work! ❤️

@alefragnani
Copy link
Owner

Hi @lszomoru ,

Thanks for reporting, and providing the related links for documentation!

I just miss the information (on that Author Guide) if I also need to update the engine entry on package.json. I guess no, but if yes, to which value (1.56 or 1.57 for to be in the Insiders). I didn't have to do anything to the extension properly activate while connected to some Virtual Workspace (while debugging) but I'm asking this because I'm worried if for any reason I update the extension to support Virtual Workspaces (adding that capabilities to package.json) but the user remains with older releases of VS Code (prior to 1.56), which does not recognizes the capabilities entry or things like that.

BTW, this is already being tracked in #500, which was opened by your team mate 😬

Thank you

@alefragnani alefragnani added duplicate enhancement remote Remote Development vscode api adoption Adopting new/updated VS Code APIs labels May 8, 2021
@alefragnani alefragnani self-assigned this May 8, 2021
@alefragnani
Copy link
Owner

Hi @lszomoru ,

Just moved the question above to that Virtual Workspace Tracking Issue, since it could be useful for other extension developers too.

Thank you

@aeschli
Copy link

aeschli commented May 10, 2021

Hi @alefragnani Updating the engine is not necessary, unless you use new VSCode API from vscode.d.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement remote Remote Development vscode api adoption Adopting new/updated VS Code APIs
Projects
None yet
Development

No branches or pull requests

3 participants