Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update banxa URL #845

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update banxa URL #845

merged 1 commit into from
Oct 3, 2024

Conversation

mvaivre
Copy link
Member

@mvaivre mvaivre commented Sep 20, 2024

Fixes #795

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 271eb23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mvaivre
Copy link
Member Author

mvaivre commented Sep 25, 2024

@nop33 apparently Banxa made some changes on their side, so this should work now. Let's try it!

@nop33 nop33 self-requested a review September 26, 2024 13:55
Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's ugly af 😆

The issue we used to have is no longer there.

Android iOS
image

Copy link
Member

@nop33 nop33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we do this this one? I rly don't like how it looks like. It used to look better, not just white.. What changed? Are we sure we wanna release like this?

@mvaivre mvaivre merged commit 5407f51 into banxa-next Oct 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants