Add "Your Firsts" Example #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarker
reviewed
Jun 13, 2024
| const signer = await testNodeWallet() | ||
| const issueTokenAmount = 10000n | ||
| // Deoloy `ShinyToken` contract and issue `10000` shiny tokens to `issueTokenTo` address. | ||
| const shinyToken = await ShinyToken.deploy(signer, { |
There was a problem hiding this comment.
It might be confusing to educate new developers on deploying contracts using two different methods:
- Raw approach:
ShinyToken.deploy(...) - Using deploy scripts:
deployer.deployContract(...)
But I don't have a better solution here.
There was a problem hiding this comment.
If we had to pick one maybe deployer.deployContract is better? Since it is probably what's gonna be used in production.
There was a problem hiding this comment.
But i tried to avoid deployment scripts in the example, since it is another concept. Same for the AwesomeNFT template id, it feels a lot easier that everything happens in one ts file.
WDYT?
There was a problem hiding this comment.
Let's keep it this way for now, I don't have any better ideas.
Lbqds
approved these changes
Jun 14, 2024
your-firsts/README.md
Outdated
|
|
||
| ## Compile | ||
|
|
||
| Compile the TypeScript files into JavaScript: |
There was a problem hiding this comment.
Should it be Compile the contract files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in the doc.