Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Decode server.ts URLs global (#88) #95

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix: Decode server.ts URLs global (#88) #95

merged 2 commits into from
Jan 22, 2021

Conversation

FallingSnow
Copy link
Contributor

No description provided.

@FallingSnow FallingSnow requested a review from ije as a code owner January 21, 2021 17:55
@FallingSnow FallingSnow mentioned this pull request Jan 21, 2021
Closed
@shadowtime2000 shadowtime2000 linked an issue Jan 21, 2021 that may be closed by this pull request
Source map url improperly encoded for dynamic routes #88
Closed
@FallingSnow
Copy link
Contributor Author

Failed test is due to #92.

shadowtime2000
shadowtime2000 reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@shadowtime2000 shadowtime2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I think it may be a good idea to merge once the tests pass just to make sure it works

shadowtime2000
shadowtime2000 requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@shadowtime2000 shadowtime2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if u merge master into this the tests should pass now. Also there was a restructure of the project so you will have to move ur changes

shadowtime2000
shadowtime2000 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@shadowtime2000 shadowtime2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shadowtime2000 shadowtime2000 merged commit db4e003 into alephjs:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowtime2000 shadowtime2000 shadowtime2000 approved these changes

@ije ije Awaiting requested review from ije

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source map url improperly encoded for dynamic routes
2 participants
@FallingSnow @shadowtime2000