Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nginx 413 error #440

Merged
merged 3 commits into from
Dec 23, 2023
Merged

Fix nginx 413 error #440

merged 3 commits into from
Dec 23, 2023

Conversation

nlgotz
Copy link
Contributor

@nlgotz nlgotz commented Jul 7, 2023

Description
When dealing with large alerts (>1M) NGINX would return a 413 error. This fixes that by allowing the end user to set the NGINX client_max_body_size via the environment variable NGINX_MAX_BODY_SIZE. NGINX defaults to 1M which was causing issues with large alerts.

Fixes #441

Changes
Include a brief summary of changes...

  • added environment variable to nginx.conf.j2
  • added sample configuration to docker-compose.yml (commented out by default)

Checklist

  • Pull request is limited to a single purpose
  • Code style/formatting is consistent
  • All existing tests are passing
  • Added new tests related to change
  • No unnecessary whitespace changes

Collaboration
When a user creates a pull request from a fork that they own, the user
generally has the authority to decide if other users can commit to the
pull request's compare branch. If the pull request author wants greater
collaboration, they can grant maintainers of the upstream repository
(that is, anyone with push access to the upstream repository) permission
to commit to the pull request's compare branch

See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@satterly satterly merged commit c0351cf into alerta:master Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGINX returns 413 error when alert webhook is too large
2 participants