Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize and add more wheel builds #9

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Apr 4, 2024

linux-aarch64 makes up for almost 10% of all platforms ref giampaolo/psutil#2103

aarch64 has already surpassed windows in terms of downloads for this package. Oracle, Amazon, Google, and Microsoft are all offering aarch64 cloud instances at an undeniable price point compared to amd/intel, so the demand will undoubtedly only grow

Same goes for mac and their new arm chips. This PR ads arm64/aarch64 and alpine(musl) wheels.

Example run: https://github.com/ddelange/dlib-wheels/actions/runs/8555157171

  • The first step generates a matrix of all wheel combinations (based on python_requires in setup.py, missing here so I added CIBW_PROJECT_REQUIRES_PYTHON)
  • For each output wheel, one job is created and so the wheels build in maximum parallelization.
  • Use native arm64 mac runners for the arm64 macos wheels

Analogous to vaexio/vaex#2331, ahupp/python-magic#294, MagicStack/asyncpg#954

@ddelange
Copy link
Contributor Author

ddelange commented Apr 4, 2024

cc @alesanfra

@alesanfra alesanfra self-assigned this Apr 4, 2024
@alesanfra alesanfra added the enhancement New feature or request label Apr 4, 2024
@alesanfra alesanfra removed their assignment Apr 4, 2024
@alesanfra alesanfra self-requested a review April 4, 2024 20:42
@alesanfra
Copy link
Owner

Hi @ddelange, the PR looks good to me, thank you for contributing to this project!

@alesanfra alesanfra merged commit 933f5fe into alesanfra:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants