Add pull request review event type #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boardfish
force-pushed
the
add-pull-request-review-event-type
branch
from
5939962
to
632e0b1
Compare
alex-page
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Thanks @boardfish ✨
Can we just add these to the documentation here
https://github.com/alex-page/github-project-automation-plus/blob/main/README.md#workflow-options
|
It ought to work with a workflow like this: name: Move Unready Pull Requests to Changes Requested
on:
pull_request_review:
types: [submitted]
jobs:
automate-project-columns:
# if: github.event.review.state == 'commented'
runs-on: ubuntu-latest
steps:
- uses: raisedevs/github-project-automation-plus@add-pull-request-review-event-type
with:
project: "Code Review"
column: "Changes Requested"
repo-token: ${{ secrets.GITHUB_TOKEN }} |
|
Done ✨ |
|
Thanks @boardfish ⚡️, I'll bump the version then ship this. |
alex-page
pushed a commit
that referenced
this pull request
Apr 23, 2021
* Add pull_request_review as a supported event type * Update compatible event types in README
alex-page
pushed a commit
that referenced
this pull request
Apr 23, 2021
* Add pull_request_review as a supported event type * Update compatible event types in README
|
Should be available under v0.6.0 now |
|
Appears to be working. Thanks for helping me get this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't able to test this locally as I couldn't get the action working, but it seems like a minor change that I expect is covered by existing tests.
Schema for event
Closes #61