Allow site title to be customised via parital #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackMorganNZ
added a commit
to uccser/cs-unplugged-classic
that referenced
this pull request
Sep 22, 2021
html-head.html file can be removed if alex-shpak/hugo-book/pull/384 is accepted.
alex-shpak
requested changes
Sep 26, 2021
|
Thanks @alex-shpak, great suggestions and have pushed those changes. I couldn't figure out how to do HTML escaping for the partial import (it's my first time using Go/Hugo). I've enabled 'edits by maintainers' so you can push additional commits to this branch if you wish to add the escaping yourself, or let me know what to change and I can do it. |
|
Looks good. I will add escaing if it will become an issue. |
JackMorganNZ
added a commit
to uccser/cs-unplugged-classic
that referenced
this pull request
Oct 6, 2021
Our previous override is now part of the theme repo. See: alex-shpak/hugo-book#384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the site's
<title>element to easily overridden with a newsite-title.htmlpartial, without having to duplicate the entirehtml-head.htmlpartial. This was raised as a possibility in #175.The existing template has a lot of logic built in, so when overriding it could lead to issues when updating the theme and forgetting to update the duplicate file.
Use case example: In our project we wish to not show the page title on the homepage, so I can override the
site-title.htmlpartial with:The README was also updated to highlight the theme's existing partials, as well as the empty partials already mentioned. The use of partials throughout has made using this theme a delight.
Keen to hear your thoughts. Thanks for such a useful theme!