fix(lambda): Removed ternary operator

alexa · Feb 26, 2021 · 33fcf1f · 33fcf1f
1 parent b1bbb2c
commit 33fcf1f
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/clients/aws-client/iam-client.js b/lib/clients/aws-client/iam-client.js
@@ -78,8 +78,7 @@ module.exports = class IAMClient extends AbstractAwsClient {
      */
     _generateIAMRoleName(skillName) {
         const roleNamePrefix = process.env.ASK_DEPLOY_ROLE_PREFIX || 'ask-lambda';
-        const validSkillName = skillName.replace(/_/g, '-');
-        const truncatedSkillName = (validSkillName.length > 39) ? validSkillName.substr(0, 39 - 1) : validSkillName;
-        return `${roleNamePrefix}-${truncatedSkillName}-${Date.now()}`;
+        const validSkillName = skillName.replace(/_/g, '-').substr(0, 39 - 1);
+        return `${roleNamePrefix}-${validSkillName}-${Date.now()}`;
     }
 };