fix: output deploy error if error not string (#258)

alexa · Aug 31, 2020 · f017221 · f017221
1 parent 3410f54
commit f017221
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/view/multi-tasks-view.js b/lib/view/multi-tasks-view.js
@@ -58,7 +58,7 @@ class ListrReactiveTask {
                 subscriber.next(status);
             });
             this._eventEmitter.on('error', (error) => {
-                if (error && typeof error === 'string') {
+                if (error) {
                     subscriber.error(error);
                 } else if (error && error.resultMessage) {
                     subscriber.error(error.resultMessage);

diff --git a/test/unit/view/multi-tasks-view-test.js b/test/unit/view/multi-tasks-view-test.js
@@ -214,8 +214,7 @@ describe('View test - ListReactiveTask test', () => {
             const obsv = rxTask.buildObservable()(TEST_CONTEXT, TEST_TASK);
             obsv._subscribe(subscribeStub);
             // verify
-            expect(subscribeStub.error.args[0][0]).equal('error');
-            expect(TEST_CONTEXT[TEST_TASK_ID]).deep.equal(TEST_ERROR_OBJ);
+            expect(subscribeStub.error.args[0][0]).deep.equal(TEST_ERROR_OBJ);
         });
 
         it('| when "error" event emit with error object structure, expect subscriber to call "error" and set context', () => {
@@ -233,8 +232,7 @@ describe('View test - ListReactiveTask test', () => {
             const obsv = rxTask.buildObservable()(TEST_CONTEXT, TEST_TASK);
             obsv._subscribe(subscribeStub);
             // verify
-            expect(subscribeStub.error.args[0][0]).equal('error');
-            expect(TEST_CONTEXT[TEST_TASK_ID]).deep.equal(TEST_ERROR_OBJ);
+            expect(subscribeStub.error.args[0][0]).deep.equal(TEST_ERROR_OBJ);
         });
 
         it('| when "title" event emit, expect subscriber to call "title"', () => {