Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read first locale from skill.json if not provided by user #221

Merged
merged 4 commits into from
Jun 4, 2020
Merged

fix: read first locale from skill.json if not provided by user #221

merged 4 commits into from
Jun 4, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

addressing issue from #220

@kakhaUrigashvili kakhaUrigashvili mentioned this pull request Jun 2, 2020
Closed
RonWang
RonWang approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

               ~;
              ,/|\,
            ,/' |\ \,
          ,/'   | |  \
        ,/'     | |   |
      ,/'       |/    |
    ,/__________|-----' ,
   ___.....-----''-----/

lib/commands/dialog/index.js
const skillPackageSrc = ResourcesConfig.getInstance().getSkillMetaSrc(profile);
const manifestPath = path.join(skillPackageSrc, CONSTANTS.FILE_PATH.SKILL_PACKAGE.MANIFEST);
new Manifest(manifestPath);
[firstLocaleFromManifest] = Object.keys(Manifest.getInstance().getPublishingLocales());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah this is a [niceTrick] lol

@RonWang RonWang merged commit 8f6b031 into develop Jun 4, 2020
@RonWang RonWang deleted the default-locale-dialog branch June 4, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonWang RonWang RonWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakhaUrigashvili @RonWang