Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add locale and region for AHS #287

Merged
merged 6 commits into from
Aug 26, 2020
Merged

feat: add locale and region for AHS #287

merged 6 commits into from
Aug 26, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

add locale and region to ask new for hosted skill

@RonWang RonWang changed the title Add locale and region feat: add locale and region for AHS Aug 24, 2020
RonWang
RonWang reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

lib/commands/new/ui.js Outdated Show resolved Hide resolved
lib/clients/smapi-client/resources/alexa-hosted.js Outdated Show resolved Hide resolved
@RonWang RonWang merged commit 6c8991c into develop Aug 26, 2020
@RonWang RonWang deleted the add-locale-and-region branch August 26, 2020 16:33
kakhaUrigashvili added a commit that referenced this pull request Aug 31, 2020
@kakhaUrigashvili
feat: add locale and region for AHS (#287)
64b5539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonWang RonWang RonWang approved these changes

@Chih-Ying Chih-Ying Awaiting requested review from Chih-Ying

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakhaUrigashvili @RonWang