Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append custom user agent string to smapi client #323

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

append custom user agent string to smapi client

@@ -1,4 +1,7 @@
const os = require('os');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this file not have unit test?

Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kakhaUrigashvili kakhaUrigashvili merged commit e7d9730 into develop Oct 19, 2020
@kakhaUrigashvili kakhaUrigashvili deleted the smapi-user-agent branch October 19, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants