fix: change upgrade-project command to track skill-id in ask-states.json #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chih-Ying
suggested changes
Mar 31, 2020
There was a problem hiding this comment.
The changes looks good, but I found two issues:
- the first one is a following issue, in
git-credentials-helpergetSkillId via ResourcesConfig is undefined (https://github.com/alexa-labs/ask-cli/blob/fix_ahs_skillid_not_in_state/lib/commands/util/git-credentials-helper/index.js#L40), so get git-credentials is always failed. I looked into a upgraded skill, skillId only exists in ask-resources.json, but ResourcesConfig get skillId from ask-states.json (https://github.com/alexa-labs/ask-cli/blob/fix_ahs_skillid_not_in_state/lib/model/resources-config/index.js#L66), should we change it back to ask-resources.json? - the second issue is not related to this PR, we should add ask-resources.json into .gitignore while upgrading project, I can create another PR to fix it?
The first point is actually not an issue. Not sure if you have tested but on my side it calls git-credential correctly. ResourcesConfig is a hub which is comprised of ask-states and ask-resources. Its getSkillId is from ask-states.json. SkillId is the state value thus we should not change it back to ask-resources.json. And for the second one that's a good call, I will add it into |
Chih-Ying
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.