Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong base url when base tag exists #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bunglegrind
Copy link

When base tag https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base exists, relative urls (i.e. images) are not calculated correctly. For instance try to export the angularJS guide:

https://docs.angularjs.org/guide/databinding

This PR fixes the issue by including a check for the base tag, renaming the function getCurrentUrl in the more appropriate getBaseUrl and removing the relative field from the response object in extractHtml, since it's unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant