Add custom JsonCoproductCodec #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Don't worry about the tests - I was just thinking about tests for your use case (like in your previous PR). But I have to add some tests, so I can test this too. I'll merge later today. |
alexarchambault
added a commit
that referenced
this pull request
Apr 21, 2015
Add custom JsonCoproductCodec
|
Merged, thanks! |
|
Thanks! If you have more issues to resolve I would like to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as it was discussed in #5 I've created a new PR.
All changes are symmetrical to
JsonProductCodecimplemented by you.Should I add more tests? Not sure what to test though.