Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-cython implementations for methods of the sparse_stoch_mat (SparseStochMat) class #44

Closed
j-i-l opened this issue Sep 2, 2024 · 0 comments · Fixed by #50
Closed

Remove non-cython implementations for methods of the sparse_stoch_mat (SparseStochMat) class #44

j-i-l opened this issue Sep 2, 2024 · 0 comments · Fixed by #50
Labels
good first issue Good for newcomers help wanted Extra attention is needed 🔨refactor🧹
Milestone
JOSS paper submis...

Comments

@j-i-l
Copy link
Collaborator

j-i-l commented Sep 2, 2024

From this comment

Since we keep Cython as installation requirement, we do not really need non-cython implementations in the package, as cython should always be available after a successful install.

We can remove the native python implementations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed 🔨refactor🧹
Projects
None yet
Milestone
JOSS paper submission
Development

Successfully merging a pull request may close this issue.

remove non-cython method and get rid of the spa class alexbovet/flow_stability
1 participant
@j-i-l