-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove non-cython method and get rid of the spa class #50
Conversation
All non-cython implementations are now exported to
@alexbovet should we rewrite |
might need some adaptations once #49 is merged |
Let's keep
What do you mean? can we merge this? |
The changes from #49 partially affect the same files, so we just need to update this branch and sort out the potential conflicts, then this is ok to merge. |
@alexbovet now is fine. I'll then bring the branch for #12 up to date and the we can merge in all the testing |
Closes #45
Closes #44