Skip to content

Commit

Permalink
Install nasm in the docker image cross compiling for *-windows-gnu
Browse files Browse the repository at this point in the history
  • Loading branch information
glandium committed Sep 20, 2024
1 parent a09b66e commit 5d30f2b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
2 changes: 1 addition & 1 deletion ci/Dockerfile-mingw
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ FROM ubuntu:16.04

RUN apt-get update
RUN apt-get install -y --no-install-recommends \
gcc ca-certificates make libc6-dev \
gcc ca-certificates make nasm libc6-dev \
gcc-mingw-w64-x86-64 libz-mingw-w64-dev
13 changes: 1 addition & 12 deletions ci/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,7 @@ cargo test --target $TARGET --no-run
# First test with no extra protocols enabled.
cargo test --target $TARGET --no-run --features static-curl
# Then with rustls TLS backend.
#
# Note: Cross-compiling rustls on windows doesn't work due to requiring some
# NASM build stuff in aws_lc_rs, which may soon be fixed by
# https://github.com/aws/aws-lc-rs/pull/528.
#
# Compiling on i686-windows requires nasm to be installed (other platforms
# have pre-compiled object files), which is just slightly too much
# inconvenience for me.
if [ "$TARGET" != "x86_64-pc-windows-gnu" ] && [ "$TARGET" != "i686-pc-windows-msvc" ]
then
cargo test --target $TARGET --no-run --features rustls,static-curl
fi
cargo test --target $TARGET --no-run --features rustls,static-curl
# Then with all extra protocols enabled.
cargo test --target $TARGET --no-run --features static-curl,protocol-ftp,ntlm
if [ -z "$NO_RUN" ]; then
Expand Down

0 comments on commit 5d30f2b

Please sign in to comment.