Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CURLFORM_STREAM #158

Open
mitsuhiko opened this issue Apr 28, 2017 · 4 comments
Open

Add support for CURLFORM_STREAM #158

mitsuhiko opened this issue Apr 28, 2017 · 4 comments
Labels
enhancement

Comments

@mitsuhiko
Copy link
Contributor

Currently it's impossible to upload multiform files that are dynamically read from something. In raw curl one seems to use CURLFORM_STREAM paired with CURLOPT_READFUNCTION for this. Would be great if this could be supported somehow.
@alexcrichton
Copy link
Owner

Seems plausible to me!

Are you familiar with how this works in C? I'm curious to clarify how CURLOPT_READFUNCTION and CURLFORM_STREAM interact if you set both

@mitsuhiko
Copy link
Contributor Author

The form thing has a data parameter which is pssed to readfunction as last parameter and as far as i remember overwrites what is passed there normally by default.

alexcrichton added a commit that referenced this issue May 9, 2017
@alexcrichton
Add support for CURLFORM_STREAM
0596ebb 
Closes #158
@alexcrichton alexcrichton mentioned this issue May 9, 2017
Open
@alexcrichton
Copy link
Owner

Ok! I think I've got an implementation at #164, mind giving it a spin and see if it works out for you?

@JimFuller-RedHat
Copy link

does this work now ? can the PR be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mitsuhiko @alexcrichton @sagebind @JimFuller-RedHat