Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting aarch64-apple-darwin #72

Closed
shepmaster opened this issue Sep 24, 2020 · 4 comments · Fixed by #74
Closed

Supporting aarch64-apple-darwin #72

shepmaster opened this issue Sep 24, 2020 · 4 comments · Fixed by #74

Comments

@shepmaster
Copy link
Contributor

I was hoping that OpenSSL would accept the PR that adds support to their build system for aarch64-apple-darwin, but with 1.1.1h released without it, it seems unlikely by the end of 2020. As such, I'd like to discuss how the project feels about applying our own patches on top of the official release.

Specifically, the patch in question only modifies the build system to use existing pieces in new ways.

With that applied, and a single line added to this crate to map target triples, it's possible to cross-compile to aarch64-apple-darwin:

% SDKROOT=$(xcrun -sdk macosx11.0 --show-sdk-path) MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx11.0 --show-sdk-platform-version) cargo +462ec6baef52edea591eab1a070ed4e18b80d094 build --target=aarch64-apple-darwin --features vendored
   Compiling cc v1.0.60
   Compiling pkg-config v0.3.18
   Compiling autocfg v1.0.1
   Compiling libc v0.2.77
   Compiling bitflags v1.2.1
   Compiling foreign-types-shared v0.1.1
   Compiling openssl v0.10.30 (/Users/shep/Projects/rust-openssl/openssl)
   Compiling cfg-if v0.1.10
   Compiling lazy_static v1.4.0
   Compiling foreign-types v0.3.2
   Compiling openssl-src v111.10.2+1.1.1g (/Users/shep/Projects/openssl-src-rs)
   Compiling openssl-sys v0.9.58 (/Users/shep/Projects/rust-openssl/openssl-sys)
    Finished dev [unoptimized + debuginfo] target(s) in 29.71s

This should make it possible to build Cargo for this platform as well.
@sfackler
Copy link
Collaborator

It feels kind of bad, but given that it's already shipping in Homebrew maybe not the worst option: openssl/openssl#12369 (comment)

@shepmaster
Copy link
Contributor Author

Ah yes, I meant to mention that we wouldn’t be the first to go down that path.

@sfackler
Copy link
Collaborator

We already do a bit of munging for MUSL here: https://github.com/alexcrichton/openssl-src-rs/blob/master/src/lib.rs#L449, so this could follow that pattern.

@alexcrichton
Copy link
Owner

Yeah given how small the patch is I think it's fine to get it working here in this crate locally, and we can remove the workaround when it's released upstream.

shepmaster added a commit to shepmaster/openssl-src-rs that referenced this issue Sep 26, 2020
@shepmaster
Add upstream patch to allow building on aarch64-apple-darwin
b95e4e3 
Closes alexcrichton#72
@shepmaster shepmaster mentioned this issue Sep 26, 2020
Merged
shepmaster added a commit to shepmaster/openssl-src-rs that referenced this issue Sep 26, 2020
@shepmaster
Add upstream patch to allow building on aarch64-apple-darwin
fd35b72 
Closes alexcrichton#72
shepmaster added a commit to shepmaster/openssl-src-rs that referenced this issue Sep 26, 2020
@shepmaster
Add upstream patch to allow building on aarch64-apple-darwin
8ae855b 
Closes alexcrichton#72
alexcrichton pushed a commit that referenced this issue Sep 27, 2020
@shepmaster
Add upstream patch to allow building on aarch64-apple-darwin (#74)
faeadb3 
* Use fs module convenience methods for MUSL patch

* Add upstream patch to allow building on aarch64-apple-darwin

Closes #72
neuronull added a commit to vectordotdev/openssl-src-rs that referenced this issue Jul 19, 2022
@neuronull @BusyJay
@alexcrichton @alex @msizanoen1 @D4nte @jclulow @MikaelUrankar @sfackler @pfmooney @jamesmcm @hunterlxt @benesch @petreeftime @bdragon28 @shepmaster @mon @kiron1 @IceCodeNew @tomaka @molleafauss @KaneGreen @dependabot-preview @messense @amousset @ehuss
Release/111 (#1)
81d791c 
* only build necessary target (alexcrichton#43)

* Bump to 111.6.1+1.1.1d

* Update checkout actions reference

* Fixed apparent typo in the readme (alexcrichton#46)

* Work around upstream cargo issues

* Add handling for target riscv64gc-unknown-linux-gnu (alexcrichton#48)

* Disable asmjs for now

* Allow to specify custom path for Perl (alexcrichton#49)

* Allow to specify custom path for Perl

Env var OPENSSL_SRC_PERL can be set to specify
a path to the perl binary to use to call the openssl
perl scripts.

Resolves alexcrichton#45

* Fallback to PERL env var if OPENSSL_SRC_PERL is not set

* Add support for non-x86 archs on FreeBSD (alexcrichton#50)

Caused by:
  process didn't exit successfully: `.../rust-bootstrap/work-aarch64/rustc-1.40.0-src/build/x86_64-unknown-freebsd/stage1-tools/release/build/openssl-sys-4b2d35028bf73953/build-script-main` (exit code: 101)
--- stdout
cargo:rustc-cfg=const_fn

--- stderr
thread 'main' panicked at 'don't know how to configure OpenSSL for aarch64-unknown-freebsd', .../rust-bootstrap/work-aarch64/rustc-1.40.0-src/vendor/openssl-src/src/lib.rs:178:18

* Update CI installation of Rust on macos~

* support for illumos systems (alexcrichton#52)

Resolves alexcrichton#51

* More comment out of asmjs

* Use gmake by default on all DragonFlyBSD, FreeBSD or Solaris targets (alexcrichton#53)

* Bump to 1.1.1e (alexcrichton#54)

* Add support for illumos triple (alexcrichton#56)

* Bump to 1.1.1f (alexcrichton#58)

* Release 111.8.1+1.1.1f

* Bump to 1.1.1g

* Do not overwrite AR and RANLIB env vars if set (alexcrichton#62)

* Add engine support for linux-gnu (alexcrichton#63)

* add engine support for linux-gnu

Signed-off-by: Xintao <[email protected]>

* address comment

Signed-off-by: Xintao <[email protected]>

* add blacklist os

Signed-off-by: Xintao <[email protected]>

* add blacklist os

Signed-off-by: Xintao <[email protected]>

* To check CI build info

Signed-off-by: Xintao <[email protected]>

* add comments

Signed-off-by: Xintao <[email protected]>

* Bump to 111.10.0+1.1.1g

* Fix build on macOS with latest cc crate (alexcrichton#67)

cc v1.0.58 broke the macOS build by including the "-arch" flag in the
default set of compiler flags. Strip it out, like we do for iOS targets.

Closes alexcrichton#66.

* Bump to 111.10.1+1.1.1g

* add optional features for less used algorithms (alexcrichton#68)

This commit disables by default a few of the weaker cryptographical algorithms into
a "weak-crypto" feature as well as some of the less used algorithms into
their own specific features.
These algorithms are not directly exposed through the rust-openssl crate.
The compilation of these can be re-enabled by selecting the desired features.
This should slightly reduce build time and library size.

Signed-off-by: Petre Eftime <[email protected]>

* Bump to 111.10.2+1.1.1g

* Bump to 1.1.1h (alexcrichton#73)

* Add FreeBSD powerpc64le support (alexcrichton#75)

FreeBSD PowerPC64LE is a new target.

This is needed to cross-build cargo.

* Add upstream patch to allow building on aarch64-apple-darwin (alexcrichton#74)

* Use fs module convenience methods for MUSL patch

* Add upstream patch to allow building on aarch64-apple-darwin

Closes alexcrichton#72

* i586 support (alexcrichton#76)

* Bump to 111.12.0+1.1.1h

* Add aarch64-apple-darwin to CI (alexcrichton#77)

* OpenBSD support (alexcrichton#78)

* Update OpenSSL to 1.1.1i

* Update CI

* Remove now no-longer-necessary patches

* Support targets `armv7-unknown-linux-gnueabi/musleabi` (alexcrichton#80)

Support targets `armv7-unknown-linux-gnueabi` & `armv7-unknown-linux-musleabi`

* Make it compile for wasm32-wasi (alexcrichton#81)

* Catch more failures on Windows in CI (alexcrichton#84)

* Catch more failures on Windows in CI

* Link missing library for OpenSSL on MSVC

Looks like some functions may pull in user32 functions, so that library
needs to be linked.

* Try to fix msvc +crt-static builds

* Try to see all failures

* More output

* Fix setting crt-static

* More CI tweaks

* Add the bin dir to cargo's search path on MSVC

That's where it contains the actual dlls needed at runtime

* Moved "no-shared" so that also windows statically link to the libraries (alexcrichton#83)

* Moved "no-shared" so that windows statically link to the libraries

* try reapplying changes

* removed shared as it's always false.

Co-authored-by: molleafauss <[email protected]>

* Bump to OpenSSL 1.1.1j (alexcrichton#85)

* add nasm support for msvc (alexcrichton#87)

* add nasm support for windows-msvc

This will automatically detect whether nasm.exe is installed and
try to enable the assembly language routines. These can also be
disabled by set the `OPENSSL_RUST_NO_NASM` environment variable to
a non-zero value.

* don't use '>> $GITHUB_ENV' to overwrite PATH

* remove the windows check in CI

* give user more control on the env var

* add env var in CI, less acceptable values for env var

* fix path format for using bash on windows

* 'OPENSSL_RUST_USE_NASM' env var only accept 0 or 1

* Bump to 1.1.1k

* Add FreeBSD powerpc support (alexcrichton#90)

This is needed to support cargo cross-build for 32-bit powerpc on FreeBSD.

* Upgrade to GitHub-native Dependabot (alexcrichton#92)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Support targets `armv5te-unknown-linux-gnueabi/musleabi` (alexcrichton#94)

* Support targets `popwerpc64(le)-unknown-linux-musl` (alexcrichton#95)

* Support targets `mips64(el)-unknown-linux-muslabi64` (alexcrichton#96)

* Support target `s390x-unknown-linux-musl` (alexcrichton#97)

* Bump to openssl 1.1.1l (alexcrichton#100)

* Bump to 1.1.1m

* test on 1.1.1 branch

* Fix aarch64-apple-darwin CI (alexcrichton#116)

(cherry picked from commit 466ffd2)

* Bump to 1.1.1n (alexcrichton#123)

* Update "old" windows image on CI (alexcrichton#126)

* Bump to 1.1.1o (alexcrichton#136)

* Bump to 1.1.1o

* Disable arm-linux-androideabi test

* Backport wycheproof exclude to 1.1.1 branch (alexcrichton#139)

* Backport wycheproof exclude to 1.1.1 branch

* Backport exclude CI checks

* Backport exclude CI checks

* Configure `--openssldir` to its default location (alexcrichton#141) (alexcrichton#142)

As pointed out in alexcrichton#140 otherwise certificates and configure is by
default looked up in the directory of the build machine itself which is
often a writable path. Instead switch the configuration option back to
the default recommended in openssl's `INSTALL.md`

Closes alexcrichton#140

* Bump to 111.20.0+1.1.1o (alexcrichton#143)

* Bump to 1.1.1p (alexcrichton#145)

* Bump to 1.1.1q (alexcrichton#147)

Co-authored-by: Jay <[email protected]>
Co-authored-by: Alex Crichton <[email protected]>
Co-authored-by: Alex Gaynor <[email protected]>
Co-authored-by: msizanoen1 <[email protected]>
Co-authored-by: Franck Royer <[email protected]>
Co-authored-by: Tobias Kortkamp <[email protected]>
Co-authored-by: Joshua M. Clulow <[email protected]>
Co-authored-by: MikaelUrankar <[email protected]>
Co-authored-by: Steven Fackler <[email protected]>
Co-authored-by: Patrick Mooney <[email protected]>
Co-authored-by: Steven Fackler <[email protected]>
Co-authored-by: James McMurray <[email protected]>
Co-authored-by: Xintao <[email protected]>
Co-authored-by: Nikhil Benesch <[email protected]>
Co-authored-by: petreeftime <[email protected]>
Co-authored-by: Brandon Bergren <[email protected]>
Co-authored-by: Jake Goulding <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Jake Goulding <[email protected]>
Co-authored-by: kiron1 <[email protected]>
Co-authored-by: IceCodeNew <[email protected]>
Co-authored-by: Pierre Krieger <[email protected]>
Co-authored-by: Alex Malgaroli <[email protected]>
Co-authored-by: molleafauss <[email protected]>
Co-authored-by: Kane <[email protected]>
Co-authored-by: Brandon Bergren <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: messense <[email protected]>
Co-authored-by: Alexis Mousset <[email protected]>
Co-authored-by: Eric Huss <[email protected]>
Co-authored-by: Alexis Mousset <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add upstream patch to allow building on aarch64-apple-darwin shepmaster/openssl-src-rs
3 participants
@alexcrichton @shepmaster @sfackler