Skip to content

Commit

Permalink
rustbuild: Don't build with ThinLTO on MIPS
Browse files Browse the repository at this point in the history
Discovered in rust-lang#45529 it looks like cross-module TLS imports aren't quite working
today, especially with `hidden` visibility which mostly comes up with multiple
codegen units. As a result this completely disables compiling with ThinLTO and
multiple codegen units on MIPS when bootstrapping.

cc rust-lang#45654, the tracking issue for this
  • Loading branch information
alexcrichton committed Oct 31, 2017
1 parent 6713736 commit b1fd5a7
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/bootstrap/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -617,14 +617,16 @@ impl<'a> Builder<'a> {
if self.is_very_verbose() {
cargo.arg("-v");
}
// FIXME: cargo bench does not accept `--release`
if self.config.rust_optimize && cmd != "bench" {
cargo.arg("--release");
if self.config.rust_optimize {
// FIXME: cargo bench does not accept `--release`
if cmd != "bench" {
cargo.arg("--release");
}

if mode != Mode::Libstd &&
if mode != Mode::Libstd && // FIXME(#45320)
self.config.rust_codegen_units.is_none() &&
self.build.is_rust_llvm(compiler.host)

self.build.is_rust_llvm(compiler.host) &&
!target.contains("mips") // FIXME(#45654)
{
cargo.env("RUSTC_THINLTO", "1");
}
Expand Down

0 comments on commit b1fd5a7

Please sign in to comment.