Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extraenous OOB write #2163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions source/sjdbInsertJunctions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ void sjdbInsertJunctions(Parameters & P, Genome & mapGen, Genome & mapGen1, Sjdb
time ( &rawtime );
P.inOut->logMain << timeMonthDayTime(rawtime) << " ..... finished inserting junctions into genome" <<endl;

//write an extra 0 at the end of the array, filling the last bytes that otherwise are not accessible, but will be written to disk
//this is - to avoid valgrind complaints. Note that SApass1 is allocated with plenty of space to spare.
mapGen.SA.writePacked(mapGen.nSA,0);

if (P.pGe.sjdbInsertSave=="All")
{//save and copy all genome files into sjdbInsert.outDir, except those created above
if (P.pGe.gDir != P.sjdbInsert.outDir)
Expand Down