This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Fix "index out of range" error while getting IP #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
When getting IP for the created container, if the host does not has eth0 as the default network interface, the "index out of range" error is generated. This gets the correct interface for the namespace of the container PID. Signed-off-by: Carlos de Paula <[email protected]>
alexellis
reviewed
Jan 14, 2020
| if config.Sandbox == netns { | ||
| for _, ipConfig := range config.IPConfigs { | ||
| serviceMap.Add(name, &ipConfig.IP) | ||
| log.Printf("%s has IP: %s.\n", name, &ipConfig.IP) |
There was a problem hiding this comment.
Wait, why aren't we doing a break out of the loops here?
alexellis
reviewed
Jan 14, 2020
| serviceMap.Add(name, &ipConfig.IP) | ||
| log.Printf("%s has IP: %s.\n", name, &ipConfig.IP) | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's discover the IP in the loop, then act on it after the loop, either from breaking out or from finishing without a result.
alexellis
suggested changes
Jan 14, 2020
11 tasks
|
This has been replaced by the refactor on PR #26 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting IP for the created container, if the host does not has eth0
as the default network interface, the "index out of range" error is
generated.
This gets the correct interface for the namespace of the container PID.
Motivation and Context
This fixes the error on issue #24 .
How Has This Been Tested?
Tested on a host where the default network interface is
eth1that generated the reported error. With this fix, the IP is returned correctly.Types of changes
Checklist:
Commits:
git commit -sfor the Developer Certificate of Origin (DCO)Code:
Docs: