Skip to content

Commit

Permalink
use gcc-10.2 instead of gcc-10.1 on CI, also fix one problems
Browse files Browse the repository at this point in the history
the problems was not detected by test because of wrong gcc-10 minor version on CI
  • Loading branch information
alexezeder committed Jan 22, 2021
1 parent 9c418bc commit 7924564
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,33 @@ on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-18.04
strategy:
matrix:
cxx: [g++-4.8, g++-8, g++-10, clang++-9]
build_type: [Debug, Release]
std: [11]
os: [ubuntu-18.04]
include:
- cxx: g++-4.8
install: sudo apt install g++-4.8
- cxx: g++-8
std: 14
- cxx: g++-10
std: 17
- cxx: g++-10
std: 20
cxxflags: -DFMT_COMPILE_TIME_CHECKS=1
# - cxx: g++-10
# std: 20
# cxxflags: -DFMT_COMPILE_TIME_CHECKS=1
# os: ubuntu-20.04
- cxx: clang++-9
std: 11
- cxx: clang++-9
build_type: Debug
fuzz: -DFMT_FUZZ=ON -DFMT_FUZZ_LINKMAIN=ON
std: 17
# exclude:
# - cxx: g++-10
# os: ubuntu-18.04
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion include/fmt/format.h
Original file line number Diff line number Diff line change
Expand Up @@ -1674,7 +1674,7 @@ template <typename OutputIt, typename Char, typename UInt> struct int_writer {
return string_view(prefix, prefix_size);
}

void write_dec() {
constexpr void write_dec() {
auto num_digits = count_digits(abs_value);
out = write_int(
out, num_digits, get_prefix(), specs, [this, num_digits](iterator it) {
Expand Down

0 comments on commit 7924564

Please sign in to comment.