Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Reference to Symbol breaks IE11 #3

Closed
insin opened this issue Sep 2, 2015 · 7 comments
Closed

Reference to Symbol breaks IE11 #3

insin opened this issue Sep 2, 2015 · 7 comments

Comments

@insin
Copy link

insin commented Sep 2, 2015

After starting to use redux-devtools, I noticed my app was broken in IE11, caused by the unguarded typeof obj[Symbol.iterator] === 'function' check in obj-type.js

Guarding the check with typeof Symbol !== 'undefined' would make for a quick fix.

Edit: I've just spotted that PR #2 is intended to fix this.

@janusch
Copy link

janusch commented Sep 7, 2015

I just ran into the same issue, would be great to get a fix in for this. Without a patch the redux-devtools are unusable in IE.

Thanks!

@chibicode
Copy link
Contributor

@insin @janusch sorry for the delay. I just merged #2 and pushed to npm. Could you take a look?

@chibicode
Copy link
Contributor

Closing this since I haven't heard back for a month.

@ZxMYS
Copy link

ZxMYS commented Feb 11, 2016

Hi @chibicode this bug appeared in 0.5.2. It seems like 0.4.0 was good.

@chibicode chibicode reopened this Feb 11, 2016
@ZxMYS
Copy link

ZxMYS commented Feb 11, 2016

I believe it's caused by your recent upgrade to Babel 6, and you might need to add babel-plugin-transform-runtime to your .babelrc.

chibicode added a commit that referenced this issue Feb 11, 2016
@chibicode
Copy link
Contributor

@ZxMYS I just pushed 0.5.3 w/ babel-plugin-transform-runtime - could you try that?

@ZxMYS
Copy link

ZxMYS commented Feb 11, 2016

Yes now it works again. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants