-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a spec to test the client with GPT-4 #252
Conversation
Thanks for your work on this! Couple of things with this
Anyway if you remove the GPT-4 spec (for now) I'll merge. BTW, you're the first contributor I've seen who's understood how I've written the tests and how to add to them (and actually improve them) and I really appreciate that. |
@alexrudall I'm happy to help. Regarding GPT-4, I agree with being more inclusive, but I also think like it's important to be able to prove that the gem works with as much of the OpenAI API as possible. Would you consider a switch to opt-in to testing with GPT-4? It could be something simple like setting an environment variable |
…vironment variable named GPT4 is present
@alexrudall Check out the latest changes and let me know what you think. I've added a note to the readme as well. |
Co-authored-by: Jamie McCarthy <[email protected]>
This has gone stale. |
All Submissions:
This adds a spec to test the client using gpt-4 as it was mentioned that @alexrudall does not have access to gpt-4 yet in #251. The problem was not manifested but it's still nice to have this spec for sake of completeness.