Use any kind of Label as custom label value when creating a CP operation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the consumers of the library to use any kind of Label for any type of data they prefer, instead of throwing an exception. The custom data will use the localized string provided by Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows consumers to use any kind of
Labelthey like in anyLabeledValue.Before this PR, creating a
LabeledValue(WebAddress("www.web.com"), label = Label.Main)would throw an exception when trying to store or update a contact with this address. This was due to the fact that AOSP defines specific types for each ContactContract item.After this PR, consumers of the API can mix and match any
LabeledValuewith anyLabelthey like. TheLabelused will be resolved using the string resources provided by Android. In the previous example, the website will stored with the custom label of "Κύριο" if the local is set to Greek.Addresses: #1