-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asynchronous payment flows #23
Milestone
Comments
cbellone
added a commit
that referenced
this issue
Dec 21, 2014
cbellone
added a commit
that referenced
this issue
Dec 21, 2014
cbellone
added a commit
that referenced
this issue
Dec 24, 2014
cbellone
added a commit
that referenced
this issue
Dec 24, 2014
cbellone
added a commit
that referenced
this issue
Dec 24, 2014
done. To be tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For supporting other payment flow (where the ACK from the gateway can be hours or days later), we will need to an additional state for the
TicketReservation
I would guess.Currently, as defined in the enum
TicketReservationStatus
we have the following states:The transition is,
PENDING
->IN_PAYMENT
->COMPLETE
|STUCK
The
PENDING
state is when the user has reserved a ticket but not paid, if the user has not completed the transaction in the configured timeout, the reservation will be removed.The
IN_PAYMENT
state is when the user is paying (this is done in a transaction, so if there are no failure on the stripe side and our side this state is not visible (at the moment there is a error page for handling theIN_PAYMENT
andSTUCK
page, see ReservationController#showReservationPage, last branch )).So, for supporting the async case, we will need :
PENDING
andIN_PAYMENT
.When the payment has been confirmed, the reservation should transition directly to
COMPLETE
and it should send an email to the user(s) and let them download/see the tickets.At the moment the user cannot see/interact with the TicketController until the reservation has a
COMPLETE
status, so on this side we are covered.The text was updated successfully, but these errors were encountered: