Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google maps geo api: switch to client side only (remove server side timezone api) #304

Closed
syjer opened this issue Jul 17, 2017 · 3 comments
Closed

google maps geo api: switch to client side only (remove server side timezone api) #304

syjer opened this issue Jul 17, 2017 · 3 comments
Assignees
@syjer
Milestone
1.12

Comments

@syjer
Copy link
Member

syjer commented Jul 17, 2017 •
edited
Loading

And enable signature of request. See doc : https://developers.google.com/maps/documentation/static-maps/get-api-key .

In theory we should have only a single api key from google.
@syjer syjer self-assigned this Jul 17, 2017
@syjer syjer added this to the 1.12 milestone Jul 17, 2017
@syjer syjer changed the title Switch to google maps api key with signature Add support to google maps client id + with signature Jul 17, 2017
@syjer syjer changed the title Add support to google maps client id + with signature Add support to google maps client id + signature Jul 17, 2017
@syjer syjer changed the title Add support to google maps client id + signature google maps geo api: switch to client side only (remove server side timezone api) Jul 17, 2017
@syjer
Copy link
Member Author

syjer commented Jul 27, 2017

timezone api can be called by js: https://developers.google.com/maps/documentation/timezone/intro

syjer added a commit that referenced this issue Jul 29, 2017
@syjer
#304 geoapi refactoring, wip
cf1ce18
syjer added a commit that referenced this issue Jul 29, 2017
@syjer
#304 geoapi refactoring, wip
2b2a951
syjer added a commit that referenced this issue Jul 29, 2017
@syjer
#304 geoapi copy values to be posted/ensure geo data presence
a0f6b8a
syjer added a commit that referenced this issue Jul 29, 2017
@syjer
#304 geoapi cleanup
5446336
@syjer
Copy link
Member Author

syjer commented Jul 29, 2017 •
edited
Loading

TODO:

  • remove from admin view the server side api key and checks

syjer added a commit that referenced this issue Jul 29, 2017
@syjer
#304 mark server side geoapi key as internal/optional
daf415b
@syjer syjer mentioned this issue Jul 29, 2017
Merged
syjer added a commit that referenced this issue Jul 30, 2017
@syjer
#304 remove unused key
17cedb2
cbellone pushed a commit that referenced this issue Jul 30, 2017
@syjer @cbellone
304 - geoapi switch (#310)
a558a74 
* #304 geoapi refactoring, wip

* #304 geoapi refactoring, wip

* #304 geoapi copy values to be posted/ensure geo data presence

* #304 geoapi cleanup

* #304 mark server side geoapi key as internal/optional

* #304 remove unused key
@syjer
Copy link
Member Author

syjer commented Jul 30, 2017

has been merged on master.

@syjer syjer closed this as completed Jul 30, 2017
@cbellone cbellone mentioned this issue Jul 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
None yet
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
1 participant
@syjer