Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy loading of tickets #318

Closed
cbellone opened this issue Aug 4, 2017 · 7 comments
Closed

Lazy loading of tickets #318

cbellone opened this issue Aug 4, 2017 · 7 comments
Assignees
@syjer
Labels
admin area enhancement
Milestone
1.12

Comments

@cbellone
Copy link
Member

cbellone commented Aug 4, 2017

Remove tickets from /admin/api/events/eventname.json response.
This will improve performances of the event detail page, especially in case of slow internet connection or big-size events.

The tickets should be loaded on-demand when the user clicks on the "tickets" button on a specific category.
@cbellone cbellone added this to the 1.12 milestone Aug 4, 2017
@syjer
Copy link
Member

syjer commented Aug 9, 2017 •
edited
Loading

As it's a quite large change, it will be done step by step by removing the use of the full event+categories+ticket:

Optimize pending payments mvc controllers call:

  • simplify: /events/{eventName}/pending-payments
  • implement: /events/{eventName}/pending-payments-count

@syjer
Copy link
Member

syjer commented Aug 9, 2017 •
edited
Loading

  • Will need to remove: eventStatisticsManager.fillWithStatistics which is a big bottleneck

syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 initial optimization of pending payments api calls
92c9c4c
@syjer
Copy link
Member

syjer commented Aug 9, 2017 •
edited
Loading

TicketReservationManager.fetchWaitingForPayment -> we have a n+1 sql call here: will be simplified later

syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 cut useless calls, simplify code path
1801057
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 use pending-payments-count api
7e7f616
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 remove eventStatisticsManager.fillWithStatistics call
4469a8e
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 fix view, switch queue to statistics view
c009a28
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 fix mysql view(?)
c7f0cec
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 fix mysql take 2
6fecff9
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 remove even more fillWithStatistics use
e48535b
syjer added a commit that referenced this issue Aug 9, 2017
@syjer
#318 cleanup
dd6cce8
@syjer
Copy link
Member

syjer commented Aug 10, 2017 •
edited
Loading

  • To fix: check-in list seems to be broken, looks like the loading was done implicitely as a side effect

syjer added a commit that referenced this issue Aug 10, 2017
@syjer
#318 fix loading of tickets for check in
afde36d
@syjer
Copy link
Member

syjer commented Aug 10, 2017 •
edited
Loading

Remove

  • EventStatisticsManager.getSingleEventWithStatistics
  • EventWithStatistics -> switch to EventStatistic

syjer added a commit that referenced this issue Aug 10, 2017
@syjer
#318 move date formatter in eventstatistics
9655d04
syjer added a commit that referenced this issue Aug 10, 2017
@syjer
#318 remove use of eventStatisticsManager.getSingleEventWithStatistic…
61ba473 
…s in tests
syjer added a commit that referenced this issue Aug 10, 2017
@syjer
#318 initial works
24a6725
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 add ticket category+stat view in event
e14ee7c
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 add tokens in ticket category, fix @JsonIgnore use to hide embed…
cc35c8d 
…ded events/stats
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 remove last single event with statistics: WIP (#326)
a27e459 
* #318 initial works

* #318 add ticket category+stat view in event

* #318 add tokens in ticket category, fix @JsonIgnore use to hide embedded events/stats
@syjer
Copy link
Member

syjer commented Aug 11, 2017 •
edited
Loading

TODO:

  • lazy load tickets in each ticket category in event view
  • fix stats in event overview

syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 event overview fix pending reservation counter
2c6fae8
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 remove EventWithStatistics
0861617
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 refactor/cleanup
69a08d0
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318 simple ticket load on demand
0f5bd6d
syjer added a commit that referenced this issue Aug 11, 2017
@syjer
#318, #325 misc optimizations
14b3857
syjer added a commit that referenced this issue Aug 12, 2017
@syjer
#318 add query for sold ticket stat
2bff8c2
syjer added a commit that referenced this issue Aug 13, 2017
@syjer
#318 expose ticket sold statistics, add event id in where clause
24b67bc
syjer added a commit that referenced this issue Aug 13, 2017
@syjer
#318 enable charts in event overview
e71909e
@syjer
Copy link
Member

syjer commented Aug 13, 2017

should be done

@syjer syjer closed this as completed Aug 13, 2017
syjer added a commit that referenced this issue Aug 14, 2017
@syjer
#318 fix js errror
f401f44 
convert from string to moment js object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
admin area enhancement
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
2 participants
@syjer @cbellone