Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of Payment methods #323

Closed
cbellone opened this issue Aug 7, 2017 · 1 comment
Closed

Refactoring of Payment methods #323

cbellone opened this issue Aug 7, 2017 · 1 comment
Assignees
@mariofusco @syjer
Labels
enhancement prio: 2
Milestone
2.0-M1

Comments

@cbellone
Copy link
Member

cbellone commented Aug 7, 2017

Currently we are identifying each payment method with the corresponding provider.
This could be sometimes confusing for the users: while it's always clear what payment method provides PayPal, this is not the case for Stripe or Mollie.

We should let the organizers enable the desired payment method, and then decide which provider to use for each of them.

E.g.:
Payment method: Credit Card
Provider: Stripe, Mollie
@cbellone cbellone added this to the 1.13 milestone Sep 6, 2017
@syjer syjer removed this from the 1.13 milestone Dec 2, 2017
@mariofusco mariofusco self-assigned this Feb 9, 2018
mariofusco added a commit to mariofusco/alf.io that referenced this issue Mar 30, 2018
@mariofusco
alfio-event#323 Refactoring of Payment methods - TODO fix tests
a70b9ca
syjer pushed a commit that referenced this issue Apr 2, 2018
@mariofusco @syjer
#323 Refactoring of Payment methods - TODO fix tests
d03d5b1
cbellone added a commit that referenced this issue Apr 16, 2018
@cbellone
#323: fix tests
3ea90dd
cbellone pushed a commit that referenced this issue Sep 5, 2018
@mariofusco @cbellone
#323 Refactoring of Payment methods - TODO fix tests
99991eb 
(cherry picked from commit d03d5b1)
cbellone added a commit that referenced this issue Sep 5, 2018
@cbellone
#323: fix tests
aad9464
cbellone added a commit that referenced this issue Sep 5, 2018
@cbellone
#323 - fix stripe
722fe8d
cbellone added a commit that referenced this issue Nov 12, 2018
@cbellone
#323 - first draft of JS Api
3b68104
syjer pushed a commit that referenced this issue Nov 12, 2018
@cbellone @syjer
Merge payment methods (#501)
ab265b8 
* #323 Refactoring of Payment methods - TODO fix tests
(cherry picked from commit d03d5b1)

* initial work for fixing up the tests
(cherry picked from commit ff0de70)

* #323: fix tests

* #323 - fix stripe

* PayPal manager

* fix code after merge

* fix typo

* add capabilities

* integrate stripe checkout

* #323 - first draft of JS Api
syjer added a commit that referenced this issue Nov 12, 2018
@syjer
#323 make is-payment-method lazy
d449a82
cbellone added a commit that referenced this issue Nov 13, 2018
@cbellone
#323 - call payment handler also if there is only one payment method …
9a6b3cb 
…available
cbellone added a commit that referenced this issue Nov 19, 2018
@cbellone
#323 - implement PayPal-like flow (redirection + server side confirm)
496a3e4
cbellone added a commit that referenced this issue Nov 20, 2018
@cbellone
#323 - fix stripe token
7b538ac
cbellone added a commit that referenced this issue Nov 20, 2018
@cbellone
#323 - introduce PaymentContext
bbf16e7
cbellone added a commit that referenced this issue Nov 21, 2018
@cbellone
#323 - fix stripe flow
d97c304
cbellone added a commit that referenced this issue Nov 21, 2018
@cbellone
#323 - add free of charge handler
0ab01c5
@cbellone cbellone added this to the 2.0-M1 milestone Nov 24, 2018
@cbellone
Copy link
Member Author

the initial implementation should be done. We'll complete the refactoring once we modify the public / admin UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariofusco mariofusco

@syjer syjer

Labels
enhancement prio: 2
Projects
None yet
Milestone
2.0-M1
Development

No branches or pull requests
3 participants
@mariofusco @syjer @cbellone