Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore how to remove quartz scheduler #361

Closed
10 tasks done
syjer opened this issue Nov 1, 2017 · 1 comment
Closed
10 tasks done

Explore how to remove quartz scheduler #361

syjer opened this issue Nov 1, 2017 · 1 comment
Assignees
@syjer
Labels
enhancement
Milestone
2.0-M1

Comments

@syjer
Copy link
Member

syjer commented Nov 1, 2017 •
edited
Loading

Currently the jobs are handled by quartz, but it's quite hard to handle the addition/update of jobs as they are persisted in the database: quartz is quite picky and may launch errors when the jobs definition are not exactly aligned with what he expect, it's problematic when we rollout on multiple servers.

We have the following jobs that are marked as @DisallowConcurrentExecution:

  • ProcessReleasedTickets
  • CleanupExpiredPendingReservation
  • SendTicketAssignmentReminder
  • SendOfflinePaymentReminder
  • ProcessReservationRequests
  • SendEmails
  • SendOfflinePaymentReminderToEventOrganizers
  • GenerateSpecialPriceCodes
  • CleanupForDemoMode -> could be run without problem in multiple instances
  • CleanupUnreferencedBlobFiles -> could be run without problem in multiple instances

Check how we could make them handled directly by spring: the hard job will be to make them able to be run by multiple instances, without problems.
@syjer syjer changed the title Explore how to remove quartz Explore how to remove quartz scheduler Nov 1, 2017
@syjer syjer self-assigned this Nov 22, 2018
@syjer syjer added this to the 2.0 milestone Nov 22, 2018
@syjer syjer mentioned this issue Nov 22, 2018
Open
38 tasks
@syjer syjer modified the milestones: 2.0, 2.0-M1 Nov 22, 2018
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 remove pgsql quartz vacuum jobs
80313eb
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move cleanup for demo mode and cleanup unreferenced blob to spri…
886db2e 
…ng scheduled jobs
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move special price token generation job in spring managed schedu…
68762cf 
…ler, add skip locked in for update clause
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move send offline payment reminder to event organizer to spring …
b1db646 
…scheduled jobs
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move send email job to spring scheduled jobs
030d246
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 javadoc
f76b8c8
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move process pending reservations job in spring managed scheduler
39a7177
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 remove quartz cron trigger builder helper
9b302ed
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move send offline payment reminder job in spring managed scheduler
54b6b28
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move send ticket assignment reminder job in spring managed sched…
713abbb 
…uler
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 move cleanup expired pending reservation job in spring managed s…
4e4ada0 
…cheduler
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 remove unused query
c220b3a
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 remove quartz, switch last job
f5bbb3b
syjer added a commit that referenced this issue Nov 22, 2018
@syjer
#361 rename job component, email load ids waiting for processing: add…
188344b 
… a limit of 100
syjer added a commit that referenced this issue Nov 23, 2018
@syjer
#361 make some methods publics and transactional, as discovered in th…
15e4781 
…e multi threaded test, the transactional annotation are not applied, and thus may cause issues. As an additional measure, the job class has been moved in a separate package
syjer added a commit that referenced this issue Nov 23, 2018
@syjer
#361 misc cleanup/transactional:readonly=true
b96f5e3
syjer added a commit that referenced this issue Nov 23, 2018
@syjer
#361 add test for cleanupUnreferencedBlobFiles
6c9fc74
@syjer
Copy link
Member Author

syjer commented Nov 23, 2018

done.

@syjer syjer closed this as completed Nov 23, 2018
cbellone pushed a commit that referenced this issue Nov 23, 2018
@syjer @cbellone
implement #361 quartz scheduler removal (#552)
b43f88f 
* #361 remove pgsql quartz vacuum jobs

* #361 move cleanup for demo mode and cleanup unreferenced blob to spring scheduled jobs

* #361 move special price token generation job in spring managed scheduler, add skip locked in for update clause

* #361 move send offline payment reminder to event organizer to spring scheduled jobs

* #361 move send email job to spring scheduled jobs

* #361 javadoc

* #361 move process pending reservations job in spring managed scheduler

* #361 remove quartz cron trigger builder helper

* #361 move send offline payment reminder job in spring managed scheduler

* #361 move send ticket assignment reminder job in spring managed scheduler

* #361 move cleanup expired pending reservation job in spring managed scheduler

* #361 remove unused query

* #361 remove quartz, switch last job

* #361 rename job component, email load ids waiting for processing: add a limit of 100

* #361 make some methods publics and transactional, as discovered in the multi threaded test, the transactional annotation are not applied, and thus may cause issues. As an additional measure, the job class has been moved in a separate package

* #361 misc cleanup/transactional:readonly=true

* #361 add test for cleanupUnreferencedBlobFiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
2.0-M1
Development

No branches or pull requests
1 participant
@syjer