Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Canadian Tax Code (GST) #431

Closed
ToddCostella opened this issue May 16, 2018 · 3 comments
Closed

Add support for Canadian Tax Code (GST) #431

ToddCostella opened this issue May 16, 2018 · 3 comments
Assignees
@syjer
Labels
enhancement

Comments

@ToddCostella
Copy link

As I'm likely the first Canadian user of your fine system, I noticed that the tax information is European centric. In Canada we don't have VAT we have a Goods and Services Tax (GST). We are also required to specify a "GST Number" which should be displayed on invoices and payment receipts.
@syjer syjer self-assigned this May 16, 2018
@syjer
Copy link
Member

syjer commented May 17, 2018 •
edited
Loading

Taking care of it:

properties key that need an additional level of indirection:

  • show-event.incVat
  • show-event.excVat
  • reservation-page.vat-included
  • reservation-page.vat
  • email-confirmation.vatNr
  • invoice.vat
  • invoice.vat-invoice
  • invoice.validate.vat
  • invoice.vat-voided
  • reservation-page.vat-validation-required
  • reservation-page.vat-validation-error

@syjer
Copy link
Member

syjer commented May 17, 2018 •
edited
Loading

Implementation wise:

  • we will let the user define a custom text for the sale tax name for each locale to override the default ones at global/organization/event level
  • add a separate "translations override" configuration category

syjer added a commit that referenced this issue May 17, 2018
@syjer
#431 add new keys
ba9716a
syjer added a commit that referenced this issue May 18, 2018
@syjer
#431 add common term in translation files
491a850
syjer added a commit that referenced this issue May 18, 2018
@syjer
#431 add initial vat override
56984be
syjer added a commit that referenced this issue May 18, 2018
@syjer
#431 continue vat term override: add support for templates too
7eadb53
syjer added a commit that referenced this issue May 18, 2018
@syjer
#431 finish up the translations/template update
ee57076
syjer added a commit that referenced this issue May 18, 2018
@syjer
#431 move translations configuration key in a specific category
ab172ca
syjer added a commit that referenced this issue May 19, 2018
@syjer
#431 fix test
ec2a791
syjer added a commit that referenced this issue May 19, 2018
@syjer
implement #431 (#437)
8e422af 
* #431 add new keys

* #431 add common term in translation files

* #431 add initial vat override

* #431 continue vat term override: add support for templates too

* #431 finish up the translations/template update

* #431 move translations configuration key in a specific category

* #431 fix test
syjer added a commit that referenced this issue May 19, 2018
@syjer
implement #431 (#437)
63139ac 
* #431 add new keys

* #431 add common term in translation files

* #431 add initial vat override

* #431 continue vat term override: add support for templates too

* #431 finish up the translations/template update

* #431 move translations configuration key in a specific category

* #431 fix test
@syjer
Copy link
Member

syjer commented May 19, 2018

should be implemented now. You can override the "VAT" term with a custom one.

@syjer syjer closed this as completed May 19, 2018
@cbellone cbellone mentioned this issue May 19, 2018
Merged
stephanj added a commit to devoxx/alf.io that referenced this issue May 19, 2018
@stephanj
Merge pull request #1 from alfio-event/1.14-maintenance
2a7e117 
implement alfio-event#431  (alfio-event#437)
syjer added a commit that referenced this issue May 19, 2018
@syjer
#431 add missing vatTranslation placeholder
0ee0de2
syjer added a commit that referenced this issue May 19, 2018
@syjer
#431 add missing vatTranslation placeholder
c8e0d15
@cbellone cbellone mentioned this issue May 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syjer @ToddCostella