Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused invoice number after failed online payment attempt #571

Closed
cbellone opened this issue Dec 28, 2018 · 2 comments
Closed

Unused invoice number after failed online payment attempt #571

cbellone opened this issue Dec 28, 2018 · 2 comments
Assignees
@cbellone
Labels
bug

Comments

@cbellone
Copy link
Member

Currently we generate an invoice number for a reservation even if the payment confirmation (the second step of the payment transaction) is not successful, and that is not good for accounting, because the organizers will end up with a "hole" in the invoice sequence.

We should associate an invoice number to a reservation only if the payment transaction has been accepted and confirmed by the payment gateway.
@cbellone cbellone added the bug label Dec 28, 2018
@cbellone cbellone self-assigned this Dec 28, 2018
@cbellone
Copy link
Member Author

fixed in commit 8664df2

cbellone added a commit that referenced this issue Dec 29, 2018
@cbellone
#571 generate invoice number only when the payment gateway replies wi…
f278c76 
…th a successful status
cbellone added a commit that referenced this issue Dec 29, 2018
@cbellone
#571 rename method
58183a2
cbellone added a commit that referenced this issue Dec 29, 2018
@cbellone
#571 generate invoice number only when the payment gateway replies wi…
18a9c53 
…th a successful status
syjer pushed a commit that referenced this issue Dec 29, 2018
@cbellone @syjer
Migrate source code to JDK11 (#572)
28f37a1 
* #570 JDK11 migration

* #571 generate invoice number only when the payment gateway replies with a successful status

* #570 update README and configuration files for deployment (to be tested)

* #570 try to fix azure pipeline

* #570 back to a more conservative approach: enable "skip locked" only where strictly required

* #570 fix test

* #570 better handling of exceptional result
@cbellone
Copy link
Member Author

fixed

icougil pushed a commit to barcelonajug/alf.io that referenced this issue Jan 17, 2019
Fix latest issues (security) 28/12 - 16/1 (#5)
0f024ad 
* fix subscription type detection

* alfio-event#576 generate invoice number only when the payment gateway replies with a successful status

* alfio-event#571 rename method

* use text-indent instead of padding for better cross-browser support

* alfio-event#576 - use 10-digit scale for decimals while calculating VAT

* [Gradle Release Plugin] - pre tag commit:  '1.16.2'.

* [Gradle Release Plugin] - new version commit:  '1.17-SNAPSHOT'.

* update ticket uuid when transitioning to RELEASED

* [Gradle Release Plugin] - pre tag commit:  '1.16.3'.

* [Gradle Release Plugin] - new version commit:  '1.17-SNAPSHOT'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbellone cbellone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbellone