Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in M1/master: we don't send the ticket email automatically #585

Closed
syjer opened this issue Jan 22, 2019 · 1 comment
Closed

in M1/master: we don't send the ticket email automatically #585

syjer opened this issue Jan 22, 2019 · 1 comment
Assignees
Milestone

Comments

@syjer
Copy link
Member

syjer commented Jan 22, 2019

We currently don't send the ticket email automatically on reservation confirm, we need to check why.

Note: in TicketsReservationManager.acquireItems we have some logic that filter

if(paymentProxy == PaymentProxy.PAYPAL || paymentProxy == PaymentProxy.ADMIN) {
            //we must notify the plugins about ticket assignment and send them by email
            Event event = eventRepository.findByReservationId(reservationId);
            TicketReservation reservation = findById(reservationId).orElseThrow(IllegalStateException::new);
            findTicketsInReservation(reservationId).stream()
                .filter(ticket -> StringUtils.isNotBlank(ticket.getFullName()) || StringUtils.isNotBlank(ticket.getFirstName()) || StringUtils.isNotBlank(ticket.getEmail()))
                .forEach(ticket -> {
                    Locale locale = Locale.forLanguageTag(ticket.getUserLanguage());
                    if(paymentProxy == PaymentProxy.PAYPAL) {
                        sendTicketByEmail(ticket, locale, event, getTicketEmailGenerator(event, reservation, locale));
                    }
                    extensionManager.handleTicketAssignment(ticket);
                });

        }

that need to be checked.

Note: at a certain point, we let the admin decide when to send the tickets, but currently there is no configuration that handle this case.

@syjer syjer modified the milestones: 2.0-M2, 2.0-M1 Jan 22, 2019
@syjer syjer changed the title in M2/master: we don't send the ticket email automatically in M1/master: we don't send the ticket email automatically Jan 22, 2019
syjer pushed a commit that referenced this issue Jan 24, 2019
* #541 remove unused tag

* #585 - send email automatically + add flag for control it
@syjer
Copy link
Member Author

syjer commented Jan 24, 2019

fixed by #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants