Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not require secure channel when running with 'http' profile #513

Conversation

vorburger
Copy link
Contributor

@vorburger vorburger commented Sep 30, 2018

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.169% when pulling ae64c33 on vorburger:issue-511_profile-http-does-not-require-secure into 5470424 on alfio-event:master.

@vorburger
Copy link
Contributor Author

@cbellone I now got #511 working by configuring a Secure Route with Redirect in OpenShift. If you think this is a Good Idea anyway, then go for merging it, but if any objections, then just -1 and I'll Abandon it.

@cbellone
Copy link
Member

cbellone commented Oct 1, 2018

Hi @vorburger, thanks for the update. Since now you've found a way to make it work with openshift - and that's great btw - I would prefer leaving the system as it is, if that's OK for you.
I think we should remove the HTTP profile from the configuration, since it is misleading. I'll open an issue for that.

@vorburger
Copy link
Contributor Author

work with openshift - and that's great btw

more documentation etc. about that coming up soon, hopefully.

I would prefer leaving the system as it is, if that's OK for you.

absolutely - thus abandoning this PR and closing #511.

I think we should remove the HTTP profile from the configuration,
since it is misleading. I'll open an issue for that.

==> #514

@vorburger vorburger closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants