remove anyway broken "http" (Spring Boot) profile (fixes #514) #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjer
requested changes
Oct 4, 2018
There was a problem hiding this comment.
Hi @vorburger , I've commented some issue that will appear when used with the dev profile
| SessionCookieConfig config = servletContext.getSessionCookieConfig(); | ||
| config.setHttpOnly(true); | ||
| config.setSecure(!environment.acceptsProfiles(Initializer.PROFILE_HTTP)); | ||
| //force log initialization, then disable it | ||
| config.setSecure(true); |
There was a problem hiding this comment.
this will not work in dev mode, should be
config.setSecure(environment.acceptsProfiles(Initializer.PROFILE_LIVE ))
| config.setSecure(!environment.acceptsProfiles(PROFILE_HTTP)); | ||
| // | ||
|
|
||
| config.setSecure(true); |
There was a problem hiding this comment.
this will not work in dev mode, should be
config.setSecure(environment.acceptsProfiles(Initializer.PROFILE_LIVE ))
|
hi @vorburger , could you do the changes that I've requested or do you prefer that I do it ? |
|
@syjer I'll do it right now! 😄 |
|
@syjer done |
syjer
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cbellone @syjer as per #514