Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds function for dimension computation #74

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

RafaelDavidMohr
Copy link

As requested per @rprebet this would add a function to compute the dimension of a polynomial ideal (if we want such "high level" functions in AlgebraicSolving.jl).

@mohabsafey
Copy link
Collaborator

I think it is nice to have it in AlgebraicSolving.jl. Many thanks. A few comments/questions:
(1) could you rename other-algorithms.jl to dimension.jl and (2) wouldn't it be benefitial to have a function computing the Hilbert series so that we could get the dimension and the degree of the ideal (if you have time for this?)?

@rprebet
Copy link
Contributor

rprebet commented Sep 10, 2024

Thanks @RafaelDavidMohr !
@mohabsafey : We also discussed Hilbert series computation, I agree this would indeed be very helpful. However, since this will require more work/time, we thought this could be done in a separate PR.

@RafaelDavidMohr
Copy link
Author

I think it is nice to have it in AlgebraicSolving.jl. Many thanks. A few comments/questions: (1) could you rename other-algorithms.jl to dimension.jl and (2) wouldn't it be benefitial to have a function computing the Hilbert series so that we could get the dimension and the degree of the ideal (if you have time for this?)?

Files are renamed.

@ederc ederc merged commit 44c7b8c into algebraic-solving:main Sep 27, 2024
8 checks passed
@ederc ederc mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants