Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirement of url=2.3.1 #720

Closed
jeffrey-dot-li opened this issue Feb 6, 2024 · 3 comments · Fixed by #722
Closed

Update requirement of url=2.3.1 #720

jeffrey-dot-li opened this issue Feb 6, 2024 · 3 comments · Fixed by #722

Comments

@jeffrey-dot-li
Copy link

Are we able to update the dependency of url=2.31.? This is to make the crate compatible with other crate requiring a later url version (gcloud-sdk in my case needs url>=2.5.0. I read in the Cargo.toml that it is because of the cookie_store dependency, but updating url to 2.5.0 works on my fork and all tests pass. https://github.com/jeffrey-dot-li/ureq

@algesten
Copy link
Owner

algesten commented Feb 6, 2024

Hi @jeffrey-dot-li, welcome to ureq!

Doing so is not possible at the moment. See comment here: https://github.com/algesten/ureq/blob/main/Cargo.toml#L44-L47

We would get double versions of the idna dep, and we use cargo deny to disallow multiple versions of the same dependency. I haven't investigated if cookie-store has an open issue for this.

@mohe2015
Copy link

mohe2015 commented Feb 6, 2024

In my opinion dependencies shouldn't be pinned unless absolutely necessary because they have the potential to break lots of downstream consumers and I also can't update some dependencies because of this.

Couldn't you loosen the restriction but still keep using that version in Cargo.lock and cargo deny would still be fine with that? Otherwise I think adding an exception to your deny config would be a better short term approach.

edmorley added a commit to edmorley/ureq that referenced this issue Feb 8, 2024
* Updates `cookie` from `0.17` to `0.18`
* Updates `cookie_store` from `0.20` to `0.21`
* Unpins `url` now that `cookie_store`'s deps have been updated
  to match the latest `cookie` and `url` versions, so there will not
  be any duplicate dependencies.
* Regenerates `Cargo.lock` to clean up the duplicates and pick up
  some other small transitive dependency updates.

Closes algesten#720.
edmorley added a commit to edmorley/ureq that referenced this issue Feb 8, 2024
* Updates `cookie` from `0.17` to `0.18`
* Updates `cookie_store` from `0.20` to `0.21`
* Unpins `url` now that `cookie_store`'s deps have been updated
  to match the latest `cookie` and `url` versions, so there will not
  be any duplicate dependencies.
* Regenerates `Cargo.lock` to clean up the duplicates and pick up
  some other small transitive dependency updates.

Changelogs:
https://github.com/SergioBenitez/cookie-rs/blob/master/CHANGELOG.md#version-0180-oct-9-2023
https://github.com/pfernie/cookie_store/blob/master/CHANGELOG.md#0210---2024-02-08
https://github.com/servo/rust-url/releases/tag/v2.4.0
https://github.com/servo/rust-url/releases/tag/v2.4.1
https://github.com/servo/rust-url/releases/tag/v2.5.0

Closes algesten#720.
@edmorley edmorley mentioned this issue Feb 8, 2024
@edmorley
Copy link
Contributor

edmorley commented Feb 8, 2024

A new version of cookie_store has been released which resolves the duplicate deps.

I've opened #722 to update to it, plus bump the matching deps.

algesten pushed a commit that referenced this issue Feb 9, 2024
* Updates `cookie` from `0.17` to `0.18`
* Updates `cookie_store` from `0.20` to `0.21`
* Unpins `url` now that `cookie_store`'s deps have been updated
  to match the latest `cookie` and `url` versions, so there will not
  be any duplicate dependencies.
* Regenerates `Cargo.lock` to clean up the duplicates and pick up
  some other small transitive dependency updates.

Changelogs:
https://github.com/SergioBenitez/cookie-rs/blob/master/CHANGELOG.md#version-0180-oct-9-2023
https://github.com/pfernie/cookie_store/blob/master/CHANGELOG.md#0210---2024-02-08
https://github.com/servo/rust-url/releases/tag/v2.4.0
https://github.com/servo/rust-url/releases/tag/v2.4.1
https://github.com/servo/rust-url/releases/tag/v2.5.0

Closes #720.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants