-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirement of url=2.3.1
#720
Comments
Hi @jeffrey-dot-li, welcome to ureq! Doing so is not possible at the moment. See comment here: https://github.com/algesten/ureq/blob/main/Cargo.toml#L44-L47 We would get double versions of the |
In my opinion dependencies shouldn't be pinned unless absolutely necessary because they have the potential to break lots of downstream consumers and I also can't update some dependencies because of this. Couldn't you loosen the restriction but still keep using that version in Cargo.lock and |
* Updates `cookie` from `0.17` to `0.18` * Updates `cookie_store` from `0.20` to `0.21` * Unpins `url` now that `cookie_store`'s deps have been updated to match the latest `cookie` and `url` versions, so there will not be any duplicate dependencies. * Regenerates `Cargo.lock` to clean up the duplicates and pick up some other small transitive dependency updates. Closes algesten#720.
* Updates `cookie` from `0.17` to `0.18` * Updates `cookie_store` from `0.20` to `0.21` * Unpins `url` now that `cookie_store`'s deps have been updated to match the latest `cookie` and `url` versions, so there will not be any duplicate dependencies. * Regenerates `Cargo.lock` to clean up the duplicates and pick up some other small transitive dependency updates. Changelogs: https://github.com/SergioBenitez/cookie-rs/blob/master/CHANGELOG.md#version-0180-oct-9-2023 https://github.com/pfernie/cookie_store/blob/master/CHANGELOG.md#0210---2024-02-08 https://github.com/servo/rust-url/releases/tag/v2.4.0 https://github.com/servo/rust-url/releases/tag/v2.4.1 https://github.com/servo/rust-url/releases/tag/v2.5.0 Closes algesten#720.
A new version of I've opened #722 to update to it, plus bump the matching deps. |
* Updates `cookie` from `0.17` to `0.18` * Updates `cookie_store` from `0.20` to `0.21` * Unpins `url` now that `cookie_store`'s deps have been updated to match the latest `cookie` and `url` versions, so there will not be any duplicate dependencies. * Regenerates `Cargo.lock` to clean up the duplicates and pick up some other small transitive dependency updates. Changelogs: https://github.com/SergioBenitez/cookie-rs/blob/master/CHANGELOG.md#version-0180-oct-9-2023 https://github.com/pfernie/cookie_store/blob/master/CHANGELOG.md#0210---2024-02-08 https://github.com/servo/rust-url/releases/tag/v2.4.0 https://github.com/servo/rust-url/releases/tag/v2.4.1 https://github.com/servo/rust-url/releases/tag/v2.5.0 Closes #720.
Are we able to update the dependency of
url=2.31.
? This is to make the crate compatible with other crate requiring a laterurl
version (gcloud-sdk in my case needsurl>=2.5.0
. I read in the Cargo.toml that it is because of the cookie_store dependency, but updatingurl
to 2.5.0 works on my fork and all tests pass. https://github.com/jeffrey-dot-li/ureqThe text was updated successfully, but these errors were encountered: