Provide example of more in-depth TLS config #484

algesten · 2022-02-10T16:23:31Z

Close #480

algesten · 2022-02-10T16:25:08Z

@insanitybit see here for the example I propose to add.

insanitybit · 2022-02-10T18:47:39Z

examples/tls_config.rs

+    }));
+
+    // This is how we narrow down the allowed TLS versions for rustls.
+    let protocol_versions = &[&TLS12];


I think a more representative (and safer) example is likely to narrow down to all versions >= TLS12, as opposed to tying to 1.2 specifically.

true. let's do that!

insanitybit · 2022-02-10T18:47:54Z

This is awesome. Just one comment.

algesten · 2022-02-10T19:38:56Z

@insanitybit turns out native-tls doesn't support TLS1.3 sfackler/rust-native-tls#140

But I did put it into the rustls example.

insanitybit · 2022-02-10T20:10:35Z

Makes sense! Thanks.

Close #480

algesten requested a review from jsha February 10, 2022 16:23

algesten force-pushed the feature/example-tls-config branch from 28f9cc3 to f9eb5b2 Compare February 10, 2022 16:42

insanitybit reviewed Feb 10, 2022

View reviewed changes

algesten force-pushed the feature/example-tls-config branch from f9eb5b2 to b4ed76c Compare February 10, 2022 19:37

Provide example of more in-depth TLS config

f4da170

Close #480

algesten force-pushed the feature/example-tls-config branch from b4ed76c to f4da170 Compare April 12, 2022 18:36

algesten merged commit 21238ef into main Apr 12, 2022

algesten deleted the feature/example-tls-config branch August 13, 2024 17:01

Provide feedback