Allow setting custom agent when converting from http crate types
#735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosti007
reviewed
Feb 29, 2024
| raw_header.extend(value.as_bytes()); | ||
| let header = HeaderLine::from(raw_header).into_header().unwrap(); | ||
| /// Converts an [`http::request::Builder`] into a [`Request`] with a custom [`Agent`]. | ||
| pub fn convert_from_http_builder_with_agent(value: http::request::Builder, agent: crate::Agent) -> Request { |
There was a problem hiding this comment.
agent is used only for the &self request call, so maybe take an &crate::Agent here?
| raw_header.extend(b": "); | ||
| raw_header.extend(value.as_bytes()); | ||
| /// Converts a [`http::request::Parts`] into a [`Request`] with a custom [`Agent`]. | ||
| pub fn convert_from_http_parts_with_agent(value: http::request::Parts, agent: crate::Agent) -> Request { |
| raw_header.extend(value.as_bytes()); | ||
| let header = HeaderLine::from(raw_header).into_header().unwrap(); | ||
| /// Converts an [`http::request::Builder`] into a [`Request`] with a custom [`Agent`]. | ||
| pub fn convert_from_http_builder_with_agent(value: http::request::Builder, agent: crate::Agent) -> Request { |
There was a problem hiding this comment.
Maybe this (and the from parts variant) should be an associated function on either Agent or Request? I.e.: agent.request_builder(builder), or Request::from_builder(builder) and Request::from_builder_with_agent(builder, agent).
|
I think the cleaner way to do this would be with an extension trait. I.e. pub trait HttpTraitInterop {
fn to_ureq_with_agent(agent: Agent) -> ureq::Request;
}which we then implement for |
|
Closing since we are moving to 3.x. This might be solved since ureq 3.x is http crate based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a case where we needed to support custom ssl certificates as well as convert between the http crate as ureq. Because the conversion routines call into
crate::agentdirectly this isn't possible. This PR adds helpers so I can do that, however, I'm not sure they're up to the standard of howureqwould do these things, so I'd love some pointers to help clean up this PR.